Topic-icon 6.2.2 Breaks my site

Active Subscriptions:

None
9 years 6 months ago - 9 years 6 months ago #47961 by jchungerford
After updating to JFBConnect v6.2.2 certain elements of my site no longer functions properly. Can someone please take a look?

www.opensourceliving.org
J 3.3.3
JS 3.2.1.5
JFBC 6.2.2
SCLogin 4.2.1
JF Social Template 2.2 (patched for JS 3.2.1.5)
Gantry 4.1.26


Btw - SCLogin doesn't show the new amazon/meetup/windowslive icons.


Also, Can I get a dl link to be able to downgrade to JFBC 6.2.1 if this cannot be resolved?
Last edit: 9 years 6 months ago by jchungerford.
The topic has been locked.
Active Subscriptions:

None
9 years 6 months ago #47962 by jchungerford
Replied by jchungerford on topic 6.2.2 Breaks my site
FYI - disabling the JFBC components and plugins fix the site. This is weird.
The topic has been locked.
Support Specialist
9 years 6 months ago #47971 by mel
Replied by mel on topic 6.2.2 Breaks my site
Can you describe specifically the problems that you're having? Please tell us exactly what isn't working and how it should look.Your description of your site not working is a little vague for someone not familiar with your site.

You stated that Amazon, Meetup and Windows Live buttons are not showing in SCLogin. I see that Meetup and Windows Live are now present on your site. However, Amazon is still missing, so please:
1. Make sure that you have configured the API Keys and Secret Keys in the JFBConnect component. If these are blank, SCLogin will skip displaying them.
2. There is a 'providers' parameter in the SCLogin module for which social networks are displayed. If this field is left blank, all providers will be shown. If you have specified the providers previously, please make sure you update this field to include the new ones that you want to display.

Thanks
-Melissa
The topic has been locked.
Active Subscriptions:

None
9 years 6 months ago #48008 by jchungerford
Replied by jchungerford on topic 6.2.2 Breaks my site
Hi Melissa,

After much testing with our template developer it appears that JFBC 6.2.2 causes the following issue in Joomla:


in "joomla_root/templates/jf_social/features/jf_scrolltop.php" on line 34 there is written this:
$("html,body").animate({scrollTop:0},500);

but if you change it with this:
$("html,body").animate({ scrollTop: 0 },500);

it fixes.

difference between those codes is that last one has spaces.......
but why after this it fixes, we don't understand.

when JFBC system plugin is enabled, joomla renders this code like this:
$("html,body").animate(,500);

it looses this code:
{scrollTop:0}


In short as a temp fix, we've altered the code in the template but it still doesn't make sense why joomla renders the code differently when JFBC system plugin is enabled. Just passing this along in case you guys want to take a look at it.

A reference link to follow:

www.joomforest.com/forum/jf-social-jooml...ms.html?limitstart=0
www.joomforest.com/forum/jf-social-jooml...update.html?start=30
The topic has been locked.
Support Specialist
9 years 6 months ago #48039 by mel
Replied by mel on topic 6.2.2 Breaks my site
Thanks for letting me know. I was able to reproduce our bug on my test site and am working on testing my solution right now. I'll let you know when I have something to try.
The topic has been locked.
Support Specialist
9 years 6 months ago #48054 by mel
Replied by mel on topic 6.2.2 Breaks my site
I believe that I have fixed this problem in the JFBCSystem plugin. We strip out our easy-tags from the page and were inadvertently stripping out more than we should have.

We are currently working on a 6.2.3 release that should be out over the next week and this fix will be included in that release. Until then, if you'd like to try the code changes, please edit your plugins/system/jfbcsystem/jfbcsystem.php file with the following:

At line 23, after the 'var $metadataTagsToStrip = array('JFBC', 'JLinked', 'SC');' line, add the following:
var $scTags;

At what's now line 41, add the following block after the 'parent::__construct($subject, $config);' line:
$scTagArray = array('SCOpenGraph','SCPinterest');
foreach(JFBCFactory::getAllProviders() as $provider)
    $scTagArray[] = 'SC'.$provider->name;
$this->scTags = implode('|', $scTagArray);

At what's now line 279, replace
$newHead = preg_replace('/\{(SC|JFBC|JLinked)(.*?)}/ui', '', $matches[0], -1, $count);
with
$newHead = preg_replace('/\{('.$this->scTags.'|JFBC|JLinked)(.*?)}/ui', '', $matches[0], -1, $count);

At what's now line 322, replace
$regex = '/\{(SC|JFBC|JLinked)(.*?)}/i';
with
$regex = '/\{('.$this->scTags.'|JFBC|JLinked)(.*?)}/i';
The topic has been locked.
Support Specialist
9 years 6 months ago #48103 by mel
Replied by mel on topic 6.2.2 Breaks my site
After a little more testing, the following code that I mentioned in my last post needs to be updated for the Open Graph tags to be rendered correctly.
$scTagArray = array('SCOpenGraph','SCPinterest');
needs to be replaced with
$scTagArray = array('SCPinterest');
The topic has been locked.