Topic-icon Validation check shows duplicate sc_login IDs

Active Subscriptions:

None
We are getting duplicate ID's on all sc_login IDs.

See attached:

File Attachment:


How do we resolve these?

Thanks.

PS... @Alzander (Alex) could you check the PM I sent you on another subject?
The topic has been locked.
Support Specialist
10 years 11 months ago #53840 by alzander
Andrew,
The login buttons all add a CSS id of the provider that the button is for. That's the older method we used to use for styling, but have since moved to a class based system, like below, that's added to each button:
class="social-login facebook jfbcLogin pull-left"
That allows targeting of each login button without duplicating the id.

To remove the id, you can edit the /components/com_jfbconnect/libraries/provider.php file. Around line 211, you'll see:
<a id="' . $loginID . '" href="javascript:void(0)" onclick="jfbc.login.provider(\'' . $this->systemName . '\');">
Just remove that id part, like:
<a href="javascript:void(0)" onclick="jfbc.login.provider(\'' . $this->systemName . '\');">
We'll have to look into removing that ID in an upcoming rev of JFBConnect as well as it's superfluous and causes CSS validation errors when the login buttons are shown more than once.

Of course, the validation error you mention shouldn't cause any functional issues as *all* browsers properly handle duplicated IDs. So, I wouldn't be too concerned with this either way.

Thanks,
Alex
The topic has been locked.
Active Subscriptions:

None
10 years 11 months ago #53846 by imnlimited
Hi Alex,

I guess that you actually meant that I should replace this:
<a id="' . $loginID . '" href="javascript:void(0)" onclick="jfbc.login.provider(\'' . $this->systemName . '\');">

with this:
<a href="javascript:void(0)" onclick="jfbc.login.provider(\'' . $this->systemName . '\');">

Seems to work now...

Thanks,


Andrew
The topic has been locked.
Support Specialist
10 years 11 months ago #53852 by mel
Yes, that was what he was suggesting. We have this issue in our tracker to address.

-Melissa
The topic has been locked.