Topic-icon Login-modal broken

Active Subscriptions:

None
5 years 4 months ago #67052 by chramb1
Login-modal broken was created by chramb1
After upgrade, my login link, set to modal, is non-operational. No errors seen in the developer inspector in Chrome.

<a href="#login-modal" role="button" data-toggle="sc-modal">Log in</a>

On click becomes:

<a href="#login-modal" role="button" data-toggle="sc-modal" class="">Log in</a>

That empty class has me raising an eyebrow.
The topic has been locked.
Support Specialist
5 years 4 months ago #67060 by mel
Replied by mel on topic Login-modal broken
Do you have any template overrides for the SCLogin module? Can you also check what version of SCLogin is shown as installed?

The "sc-modal" is no longer present in our code. We use some more standard Joomla code to launch modals now. The fact that you're seeing that makes me think it's not been updated properly or is being overridden.

-Melissa
The topic has been locked.
Active Subscriptions:

None
5 years 4 months ago #67063 by chramb1
Replied by chramb1 on topic Login-modal broken
Looks like the latest version, but also, yes, overrides. Am I looking to refactor my overrides for new code? I'm cool with that; it's not big.

 

 
Attachments:
The topic has been locked.
Support Specialist
5 years 4 months ago - 5 years 4 months ago #67064 by mel
Replied by mel on topic Login-modal broken
Yes, all three of those files have changed.

* socialLogin.php has a few minor changes.
* login.php is pretty extensively changed to be compatible with Joomla 4. ** This is the file where the modal pops up **
* joomlaLogin_horizontal is moderately changed.

My suggestion is to grab the SCLogin 8.x version and diff those files with the ones from 9.x. You can get it here .
Last edit: 5 years 4 months ago by mel.
The following user(s) said Thank You: chramb1
The topic has been locked.
Active Subscriptions:

None
5 years 4 months ago #67065 by chramb1
Replied by chramb1 on topic Login-modal broken
Perfect.

Before we close this out, any chance you guys will ever release your customization for the modal login on YOUR main page? It's very attractive and would be a great starting point for those of us who craft our own... ;)
The topic has been locked.
Support Specialist
5 years 4 months ago #67069 by mel
Replied by mel on topic Login-modal broken
It's probably a little hidden, but if you check out our Common Support Questions for SCLogin , look at the "How can i open the SCLogin Modal Popup with a regular link?" question. This basically describes how we've done the modal popup.

Additionally in the mod_sclogin/helper.php file, we use the commented out section in the getUserMenu method for list view to display our drop down.

Also the "How can I add social network "Connect" buttons in the user menu?" common support question shows how we add the Connect buttons to that dropdown menu.

Clear as mud, right? I'll add a to-do to update our documentation on how to do this :)

-Melissa
The topic has been locked.
Support Specialist
5 years 4 months ago #67070 by mel
Replied by mel on topic Login-modal broken
Also, we definitely appreciate the feedback. Keep it coming as you see any oddities!
The topic has been locked.
Active Subscriptions:

None
5 years 4 months ago #67071 by chramb1
Replied by chramb1 on topic Login-modal broken
No, that part I get. If you'll look, I do mine the same way.

I'm talking your styling. I really like it. I'd love to see YOUR overrides ;)
The topic has been locked.
Active Subscriptions:

None
5 years 4 months ago #67072 by chramb1
Replied by chramb1 on topic Login-modal broken
 

Pretty ;)
Attachments:
The topic has been locked.
Support Specialist
5 years 4 months ago #67073 by mel
Replied by mel on topic Login-modal broken
Ahh gotcha. That makes it easier to explain...

* The only template override that we do of our module is for logout.php. I don't even remember what we do in there tbh.
* The theme in SCLogin that we use is the included sourcecoast theme.
* The JFBConnect component has Load Bootstrap CSS set to version 4, and Load Font Awesome to Yes.
* Attached are some screenshots of how we have SCLogin configured.
Attachments:
The following user(s) said Thank You: chramb1
The topic has been locked.