sc_bootstrap4.css and DOM elements

CyrusXxX
Offline

Active Subscriptions:

None

2 years 6 months ago #67484 by CyrusXxX

sc_bootstrap4.css and DOM elements was created by CyrusXxX

Hello dear support I am using SC Login with JFBConnect and would like to report 2 things:Since my template loads bootstrap 4 I have disabled loading of it in JFBConnect since I do not need it to load twice but SC Login tries to load it anyway ( file sc_bootstrap4.css ) I have checked instalation files and that file it tries to load does not exist. So I would like to see it solved.Secont thing is related to DOM elements not having unique IDs. I know that this is not a problem but could you dedicate unique IDs for this module?

I have provided screenshots for you below with settings on my project.
prntscr.com/1u8d59h
prntscr.com/1u8d58z
prntscr.com/1u8d59p

Thank you!

The topic has been locked.

mel
Offline

Support Specialist

2 years 6 months ago #67485 by mel

Replied by mel on topic sc_bootstrap4.css and DOM elements

1. SCLogin trying to load the bootstrap file regardless of JFBConnect's setting looks like a bug. You can try the following code to fix it.

In /modules/mod_sclogin/helper.php around line 72, replace

if($this->isJFBConnectInstalled)

with

if($this->isJFBConnectInstalled && JFBCFactory::config()->get('jquery_load'))

2. The inclusion of sc_bootstrap4 instead of the correct sc_bootstrap5.css was a bug that was fixed in the 9.0.170 release.

3. DOM IDs - I've added an issue to our tracker to fix this. Should be an easy thing for the next release.

-Melissa

The topic has been locked.

CyrusXxX
Offline

Active Subscriptions:

None

2 years 6 months ago #67486 by CyrusXxX

Replied by CyrusXxX on topic sc_bootstrap4.css and DOM elements

Melisa thank you for quick replay I am glad to report that code change was success.

Thank you again!

The topic has been locked.

mel
Offline

Support Specialist

2 years 6 months ago #67487 by mel

Replied by mel on topic sc_bootstrap4.css and DOM elements

Thanks for letting me know. The change is checked in for our next release.

The topic has been locked.

Start
Prev
1
Next
End

SourceCoast Login

sc_bootstrap4.css and DOM elements