Social Buttons issues - fixing

joomleb
Offline

Active Subscriptions:

None

2 years 2 months ago - 2 years 2 months ago #67829 by joomleb

Social Buttons issues - fixing was created by joomleb

Hi guys,
testing PHP 7.4.27 + Joomla 3.10.6 (Helix Ultimate 1.1.4) + JFBConnect last 9.x (SCLogin)

1 - Does not matter if "JFBC Configuration > Advanced > Enable Social Registration" is setted Yes or No, the Social Buttons are always shown on Joomla Login / Joomla Registration pages

While, does not matter the "JFBC Configuration > General > Login / Logout > Integrate into Joomla Login: …" settings, when the "JFBC Configuration > Advanced > Enable Social Registration: No", the Social buttons should be hidden in the Joomla Registration page

(While the "SCLogin > Social Buttons Setting > Show Social Login Button(s): Hide / Show" etc. settings are only applied into the SCLogin module)

2 - Many thanks to your improvement: www.sourcecoast.com/forums/sclogin-enhan...nment-center-missing
a "SCLogin Module > Social Button Settings > Alignment: center" setting has been added. It is running by adding a text-align: center class to the code, but in this way it is only running for the Social Icons into the SCLogin module.
A similar setting is missing for the Joomla Login / Joomla Registration pages. The issue could be simply solved also not adding another setting, but just appling this CSS:

div.sourcecoast.login {
justify-content: center;
display: flex;
}

when "Center" is setted into the SCLogin module (instead to use the text-align: center class).
Anyway, that Joomla Login / Joomla Registration pages setting (managed by JFBC) should be "justify-content: center;" by default because by default the Joomla Login / Joomla Registration pages layouts are "centered"

Last edit: 2 years 2 months ago by joomleb.

The topic has been locked.

mel
Offline

Support Specialist

2 years 2 months ago #67842 by mel

Replied by mel on topic Social Buttons issues - fixing

1. I understand the confusion there. To hide the buttons in the registration view if the setting is disabled, you can use the following workaround (which I'll check in the change).
In /plugins/system/jfbcsystem/jfbcsystem.php around line 138, replace

if (JFBCFactory::easytags()->canExtendJoomlaForm('registration', false, $showLoginWithJoomla))

with

if (JFBCFactory::config()->get('social_registration') != 0 && JFBCFactory::easytags()->canExtendJoomlaForm('registration', false, $showLoginWithJoomla))

2. We can't just use the setting from SCLogin for the JFBConnect component, as not all users also use the SCLogin module. I'll have to think about how to best update the styling when the component adds the buttons (like with easy-tags or the login/registration views), whether a new setting or moving some settings up to the component. In the meantime, it sounds like you have temporarily added a style to your page. I'll adding an issue to the tracker to address this.

-Melissa

The topic has been locked.

joomleb
Offline

Active Subscriptions:

None

2 years 2 months ago #67843 by joomleb

Replied by joomleb on topic Social Buttons issues - fixing

Hi Melissa,
really many thanks, I'm staying tuned here...

The topic has been locked.

Start
Prev
1
Next
End

SourceCoast Login

Social Buttons issues - fixing