Log in | Register
  1. Forum
  3. JFBConnect
  5. JFBConnect Pre-Sales Questions
  7. JFBConnect Compatibility with Other Third-Party Login modules?

Topic-icon JFBConnect Compatibility with Other Third-Party Login modules?

Active Subscriptions:

None
11 years 2 months ago #30933 by planethop
I hope so. Crossing my fingers.
The topic has been locked.
Support Specialist
11 years 2 months ago #30996 by alzander
Hey guys. I just tried the minor code change above and I'm not seeing any difference. The popup that's appearing looks to be coming from the improved login extension, not JFBConnect. So, I'm really not seeing any change with this patch.

I did some testing and tried to shuffle things around the best I could. Unfortunately, I don't know the Dojo framework that's being used here, so I don't know how the process of attaching Javascript events, stopping other ones, and the general flow should work. My ugly code changes above did seem to work for me. I'd much prefer a 2 line change as well, but I can't seem to figure that out.

On a side note, we've definitely decided that the next big JFBConnect release is going to have a vastly improved Login module. I can't guarantee it's looks or full functionality will be the same as Improved Login, which is pretty nice, but it will definitely be an imrpvoment (design and functional) over the current SCLogin module. The update will be a part of the 5.1 release, due out in April.

I'm still more than willing to help with this issue, but I just don't know what to try next other than the ugly changes above. If there's another patch from the developer, we'll gladly test. I'm afraid I won't be able to fix much of what they recommend though with my lack of knowledge regarding their framework.

Keep me posted on what you find,
Alex
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #30997 by davcar1
Alex,

In /modules/mod_improved_ajax_login/mod_improved_ajax_login.php (line 267)

if (window.regParams) dojo.mixin(params, window.regParams);
if (!window.ologin) window.ologin = new WW.Login(params);
";


changed to:

if (window.regParams) dojo.mixin(params, window.regParams);
if (!window.ologin) window.ologin = new WW.Login(params);
var fi = dojo.byId('facebookImg');
if (fi) dojo.connect(fi, 'onclick', function(e) {
e.stopPropagation();
jfbc.login.login_custom();
});
";



And it worked! I'm registering new users using the facebook icon on mod_improved_login and it's calling JFBConnect (all the JomSocial fields are being correctly mapped, including facebook avatar). I don't know if it will work with the buttons, but definitely does for the Icon.

I'm using the Facebook App ID on the module's config, but it doesn't seem to be interfering with other JFBConnect functionalities. Maybe the Dojo is not propagating anymore with the changes above..

Anyway one could also try your social.php trick (together with the suggested patch above)
<?php if ($socialpos=='XYZ') require dirname(__FILE__).'/social.php'; ?>

to avoid enabling the module's facebook connect...
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #31021 by planethop
What version of are you using? I don't see those lines of code in the /modules/mod_improved_ajax_login/mod_improved_ajax_login.php

I am using version 1.149
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #31025 by davcar1
Hi,

I'm using 1.186
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #31026 by planethop
Hmm, I can't upgrade right now because of certain code changes made by Offljan on my current version.

Guess I will have to modify social.php as Alex suggested?
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #31044 by davcar1
Yeah, Alex patch also works. You should give it a try ;)
The topic has been locked.
Support Specialist
11 years 2 months ago #31072 by alzander
Glad to hear something works. Sorry my is a nasty chunk of changes, but it's about the best you can get from me due to my lack of knowledge of their extension.

Best of luck, and keep us posted on anything you find, fix, or run into.

Thanks,
Alex
The topic has been locked.
Active Subscriptions:

None
11 years 2 months ago #31082 by planethop
Alex, regarding this step: "Then, the final step is to edit the theme.css.php file. You need to search for socialIco and btnIco and for each instance, add a new setting called socialIcoJfbc and btnIcoJfbc, respectively. There's a lot of them, but get them all. When done, a block like: "

I am a little confused. I cannot seem to figure out how to make the changes based on the example you provided.

The code from the file is: *removed*
The topic has been locked.
Support Specialist
11 years 2 months ago #31109 by alzander
I removed the large amount of code you added. I believe the files are slightly different with your version vs what I was working with, which is why I can't just give the file with the updates.

I do realize that I missed saying something above. You need to search for socialIco, btnIco, *and* loginBtn. The example I gave above was for loginBtn, but without mentioning that, it was likely pretty confusing. As another example, you just need to do a search through that files contents for "socialIco" and "btnIco" and "loginBtn". Each time you see that text, duplicate it with a new setting name called "socialIcoJfbc" and "btnIcoJfbc" and "loginBtnJfbc". So, if you search for "btnIco", you'd find the following block of code:
.btnIco {
  display: block;
  float: left;
  background: transparent no-repeat 1px center;
  width: 20px;
  border-right: 1px #<?php echo $buttoncomb[1]?> solid;
  box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
  -webkit-box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
}
Update that to be:
.btnIco,
.btnIcoJfbc { ##### add this new .btnIcoJfbc line and make sure you put a , at the end of the line above
  display: block;
  float: left;
  background: transparent no-repeat 1px center;
  width: 20px;
  border-right: 1px #<?php echo $buttoncomb[1]?> solid;
  box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
  -webkit-box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
}

Hope that helps, and keep us posted,
Alex
The topic has been locked.
  1. Forum
  3. JFBConnect
  5. JFBConnect Pre-Sales Questions
  7. JFBConnect Compatibility with Other Third-Party Login modules?
From the Blog
Facebook | Twitter | LinkedIn | Blog RSS