Topic-icon After update to 3.1.2 stopped work modal popup

Active Subscriptions:

None
10 years 6 months ago #37249 by vidma
Hi,

After module update from version 3.1.0 to 3.1.2 stopped work modal popup. I had rolled back to older version for now and not sure what caused the problem (could be CSS file as I had override it to fit my design) - SPFS web site .
The topic has been locked.
Support Specialist
10 years 6 months ago #37277 by alzander
Vidma,
I'm not sure either. We'd have to see the problem in action. There were numerous Javascript and CSS changes in this release to target them more specifically to our SCLogin module and reduce conflicts with other extensions. In general, it's gone well so far, but we'll gladly help investigate any issues you may have once we see the problem on your site.

Thanks,
Alex
The topic has been locked.
Active Subscriptions:

None
10 years 6 months ago #37286 by vidma
OK, I updated it again. SPFS website . So you can investigate the issue.
The topic has been locked.
Support Specialist
10 years 6 months ago #37319 by alzander
Can you clear your Joomla caches? If that still doesn't work, then something didn't go right with the upgrade. There's some code in your HTML that looks like:
<script type="text/javascript">
jQuery(document).ready(function() {
    jQuery("#login-modal").appendTo("body");
});
That is the code from the previous release of the SCLogin module and will not work with the new version.

We'll need to get to the bottom of why the upgrade didn't work properly or why the old data (caching?) is still being used.

Thanks,
Alex
The topic has been locked.
Active Subscriptions:

None
10 years 6 months ago #37407 by vidma
OK, it solved. It was module override of joomlaLogin_vertical.php. I had used to change the REMEMBER ME position. So I had made changes on new file and now the modal popup window works.

Thanks.
The topic has been locked.
Support Specialist
10 years 6 months ago #37418 by alzander
Awesome. Very glad to hear you got that going. Should you need anything else, just let us know.

Finally, if you haven't already, please consider leaving a rating and review for SCLogin, or our support, on the Joomla Extension Directory. It certainly isn't required, but is very appreciated:
extensions.joomla.org/extensions/access-...authentication/24054

Thanks,
Alex
The topic has been locked.
Active Subscriptions:

None
10 years 6 months ago #37814 by jimsparkman
Hello Alex,

Actually, I had an issue with the modal not dropping down after upgrading from 3.1.1 to 3.1.2.

In 3.1.1, I had 'Load jQuery' turned off because my template already loads jQuery. And it had been working fine this way.

After I upgraded to 3.1.2, the modal stopped working. So I tried turning 'Load jQuery' back on, and that worked. Seems OK again.

But, I have wondered why it wasn't necessary in 3.1.1, but is necessary in 3.1.2. And I wonder if there may be issues in some browsers, etc. that I just don't know about yet. An explanation would help me understand that risk

Thanks much, Alex.
The topic has been locked.
Support Specialist
10 years 6 months ago #37832 by alzander
Jim,
The v5.1.0 and v5.1.1 releases had a separate setting for "Load jQuery" and "Load Bootstrap" for each of those Javascript files. Unfortunately, loading those standard files (or relying on sites to load them already) had tons of conflicts with extensions loading jQuery or the Bootstrap Javascript multiple times, which causes conflicts with some features.

In v5.1.2, we moved to a new compatibility layer. The "Load jQuery" setting now loads a combined jQuery and Bootstrap Javascript file which is meant only for JFBConnect and the SCLogin module. That shields it from other conflicts that may be on your site. If disabled, then you should have jQuery and Bootstrap loading on your site already and JFBConnect will detect and use that.

So, "Load jQuery" is by far the safest and most compatible method, but it means loading one more, slightly different, version of jQuery and Bootstrap.

I hope that helps explain,
Alex
The topic has been locked.
Active Subscriptions:

None
10 years 6 months ago #37837 by jimsparkman
Alex,

Great explanation and I suspected as much, wish more developers would take the same or similar approach.

Thanks very much!
The topic has been locked.