Topic-icon Validator W3

3 years 8 months ago #66559 by alechu
Validator W3 was created by alechu
validator.w3.org/nu/

In this validator, I got 5 errors related to SCLogin:











Please correct them!
The topic has been locked.
Support Specialist
3 years 8 months ago #66560 by mel
Replied by mel on topic Validator W3
I put out a release of SCLogin v8.4.5 that should correct the top 4 issues. The last (div a child of span) requires a change in JFBConnect and thus more testing.

In the meantime, if you'd like to test a workaround, change /components/com_jfbconnect/libraries/widget/login.php at line 153 - change the span to a div. If you do the change yourself, you'll have to make sure you don't break the jfbconnect styles if they're targeting a span instead of a div. I'll put it in our issue tracker for the next release of JFBConnect.

-Melissa
The topic has been locked.
3 years 8 months ago #66562 by alechu
Replied by alechu on topic Validator W3

mel wrote: I put out a release of SCLogin v8.4.5 that should correct the top 4 issues. The last (div a child of span) requires a change in JFBConnect and thus more testing.

In the meantime, if you'd like to test a workaround, change /components/com_jfbconnect/libraries/widget/login.php at line 153 - change the span to a div. If you do the change yourself, you'll have to make sure you don't break the jfbconnect styles if they're targeting a span instead of a div. I'll put it in our issue tracker for the next release of JFBConnect.

-Melissa

Thanks for the speed! Now there is only 1 error left.
The topic has been locked.
Support Specialist
3 years 8 months ago #66563 by mel
Replied by mel on topic Validator W3
Correct. For the last issue - just follow the instructions in my post if you want to do the change on your own before we get out another release.
The topic has been locked.
3 years 7 months ago - 3 years 7 months ago #66647 by alechu
Replied by alechu on topic Validator W3
I have updated this module to version 8.4.6 and now I see these 2 errors:

1)

2)
Last edit: 3 years 7 months ago by alechu.
The topic has been locked.
Support Specialist
3 years 7 months ago #66652 by mel
Replied by mel on topic Validator W3
For error #1,
In joomlaLogin_horizontal.php at line 73, change to
<input id="sclogin-remember" type="hidden" name="remember" class="inputbox" value="yes"> title="Remember Me" />
In joomlaLogin_vertical.ph line 76
<input id="sclogin-remember" type="hidden" name="remember" class="inputbox" value="yes" title="Remember Me" />

We missed that one before. Hidden input can't have "checked" according to validation. Let me know if that fixes it and I'll check in the changes.

For error #2, we now longer have the span in the latest JFBConnect. It's a div now. You must update JFBConnect (not just SCLogin module) to resolve that (or you can do the fix yourself for components/com_jfbconnect/libraries/widget/login.php that I mentioned in an above post).

-Melissa
The topic has been locked.