JFBConnect Compatibility with Other Third-Party Login modules?

Re: JFBConnect Compatibility with Other Third-Party Login modules?

I have looked, I'm not sure what's happening though. This is getting back into an area of not knowing your login module well enough. It will take some time to look into and understand what's going on with their extension. At this point, again, you may want to contact their developers to see if they understand the issue better and can provide a solution faster.

We'll try to get you an answer later this week, but I can't guarantee anything faster than that. There are other issues that are JFBConnect-specific we're working on right now for some users. Sorry for the trouble.

Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Tried the developer... nothing back.  Will appreciate your help - when you have the chance.
Very visible issue, so I'm concerned.
Thanks.

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Sorry for the delay in getting back to this. We've been swamped with the upcoming v5.0 release of JFBConnect and v2.0 release of JLinked. I finally had some time to investigate further, and think I found the issue.

In the tmpl15.php file, there are actually 2 lines that include the social.php file:

Code:

      <?php if (@$_SESSION['oauth'] && $socialpos=='top') require dirname(__FILE__).'/social.php'; ?>

and

Code:

      <?php if (@$_SESSION['oauth'] && $socialpos=='bottom') require dirname(__FILE__).'/social.php'; ?>

I had you change the first one above, where $socialpos=='top'. My guess is that you have the module parameter set to show the social button at bottom, so my change made the social.php file be included in both spots. Since that's what you're seeing, I'm pretty sure I'm on the right track...

Anyways, the fix should be to undo the change I suggested above and then modify the 2nd inclusion line. When done, you should have the $socialpos=='top' line look like:

Code:

      <?php if (@$_SESSION['oauth'] && $socialpos=='top') require dirname(__FILE__).'/social.php'; ?>

Frankly, you could even delete that line, since it should never execute (since $socialpos is not equal to 'top'). Then, the bottom line should look like:

Code:

      <?php require dirname(__FILE__).'/social.php'; ?>

As always, test, and let us know how it goes. Things are finally settling down a little so we should have a little more time to investigate extra stuff like this that isn't directly related to our extensions.

Best of luck,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,
Thanks for the time helping out on this.
I made the suggested changes, and I don't see any changes.

1. If  Facebook is enabled in the backend of the Improved Ajax Login; the Login with Facebook button shows up; but when you click on it, you still get 2 Facebook login popups.

2.  If  Facebook is Not enabled in the backend of the Improved Ajax Login; the Login with Facebook button does not show up at all.

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

I'm facing the same problems with this module, trying to integrate the facebook login (and in the registration form also) with JFBConnect, mainly because of JomSocial profile..

I'm running Joomla 2.5.8, by the way. This login/register module/plugin is top (I think is the best I've seem for joomla, so far) and it will be great when we manage to get it to work with JFBConnect...

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Can either of you send me the full module. Planethop, I know you've sent the template directory. If you sent the whole thing, I think I lost it. Please Private Message or email it to me ([email protected])

We'll actually install it and see if we can find some step by step directions to take to integrate JFBConnect with it.

Thanks,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex, I emailed you the files. Thanks.

- Ash

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,

I've also sent you the module, screenshots and the conversation I've had with the module developer. My configuration is slightly different from planethop and a bit more complicated, but I'm sure it won't be a problem.

Thanks for the greatest support I've ever had!

David

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Thanks, both of you, for sending the files. I have some ideas to try and implement. Feedback, as always, is welcome. I haven't tried every setting and don't expect things to be perfect here.. but should be.. better current/smile

First, Facebook integration must be disabled in the module. If you enable it, it's going to conflict and cause issues with JFBConnect.
Next, undo any changes I've told you to do. That way we're starting fresh and all in the same spot.

Now, edit the tmpl15 or tmpl25 file for your Joomla version. Search for "social.php". Remove the @$_SESSION['oauth'] && portion from each line so each should look like:

Code:

        <?php if ($socialpos=='XYZ') require dirname(__FILE__).'/social.php'; ?>

Where XYZ is either 'top' or 'bottom'. There should be 3 lines you update like that.

Then, edit the social.php file. Update it so the main code area looks like below. The specific lines to add are noted:

Code:

<?php if ($socialpos == 'bottom'): ?>

<div class="loginBrd" xmlns="http://www.w3.org/1999/html"><div class="loginOr"><?php echo JText::_($v15? 'IAL_OR':'COM_USERS_OR')?></div></div>
<?php endif;?>
<?php if ($icontype == 'socialIco'):?>
  <div style="text-align:center; height:36px; *display:inline">
    <div class="socialIcoJfbc" title="JFBCONNECT" onclick="jfbc.login.login_custom()">  // ADD THIS
      <div class="socialImg" id="facebookImg"></div></a> // ADD THIS
    </div> // ADD THIS
    <?php foreach($_SESSION['oauth'] as $oauth):?>
    <div class="socialIco" title="<?php echo JText::_("IAL_LOGIN_WITH_".strtoupper($oauth->alias)) ?>">
      <div class="socialImg" id="<?php echo $oauth->alias?>Img"></div>
    </div>
    <?php endforeach;?>
  </div>
<?php else:?>
<span onclick="jfbc.login.login_custom()" class="loginBtnJfbc submitBtn">// ADD THIS
    <span class="btnIcoJfbc facebookIco"> </span>JFBCLogin Login</span>// ADD THIS
  <?php foreach($_SESSION['oauth'] as $oauth):?>
  <span class="loginBtn submitBtn"><span class="btnIco <?php echo $oauth->alias?>Ico"> </span><?php echo JText::_("IAL_LOGIN_WITH_".strtoupper($oauth->alias)) ?></span>
  <?php endforeach;?>
<?php endif;?>
<?php if ($socialpos == 'top'): ?>
  <br class="socialBR" />
  <div class="loginBrd"><div class="loginOr"><?php echo JText::_($v15? 'OR':'COM_USERS_OR')?></div></div>
<?php endif;?>

Then, the final step is to edit the theme.css.php file. You need to search for socialIco and btnIco and for each instance, add a new setting called socialIcoJfbc and btnIcoJfbc, respectively. There's a lot of them, but get them all. When done, a block like:

Code:

.loginInf,

.loginErr,
.loginBtn span,
.loginBtn, {
  display: inline-block;
  <?php $fonts->printFont('btnfont', 'Text'); ?>
}

should be changed to:

Code:

.loginInf,

.loginErr,
.loginBtn span,
.loginBtnJfbc span, # add This
.loginBtn,
.loginBtnJfbc {  # Add this
  display: inline-block;
  <?php $fonts->printFont('btnfont', 'Text'); ?>
}

It'll be tedious, but hopefully worth it.

Let us know how it goes, and good luck!
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,

I'm gonna test it first thing in the morning tomorrow (GMT -0300 here lol). I'll give you feedback, for sure.

Do you know if those changes break the module's original Google and Windows Live oauth plugins? Can they coexist with JFBConnect integration?

I was reading the forum the other day and saw a lot of people asking for a vertical SCLogin layout... I understand when you say designing such modules is not sourcecoast core business and agree with you...  So, why don't you try with the module's developer some sort of partnership, where he could implement a native JFBConnect profile integration in module settings?  As this login module solves part of the vertical login users ask so much and has a great design and potential, you could benefit from offering this as a recommended solution for these cases... at least it fits on most template's top header.

This could be interesting from a commercial point of view, as the core business wouldn't conflict and both of you could increase the new users subscriptions leveraging each other audience...  Just a thought, of course.

Thanks for your efforts and truly wish to help your customers. I can't say enough how much your support is valuable and it's indeed a great part of the user's experience. REALLY appreciate it and already recommended Sourcecoast at my college.

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,

The module developer told me to add the following piece of code:

dojo.connect(dojo.byId('facebookImg'), 'onclick', function(e) {
    e.stopPropagation();
    jfbc.login.login_custom();
  });


this this file:
/modules/mod_improved_ajax_login/mod_improved_ajax_login.php line 267   (but as he had access to my FTP and did the changes himself, I've noticed that this code is on line 533, actually..)


I've tested it (before applying your suggested patch) and it appears to be working ok. The facebook user is mapped on FFBConnect User Map tab and  JomSocial profile data is being populated. Could you assess that change and tell us if it breaks something in JFBConnect?


p.s. With this code change, now I'm able to remove the Facebook API keys from his module's facebook component..

p.s2  Spoke too soon, JomSocial started acting weird after the module patch, opening facebook popups and telling me everytime that my profile was successfully connected to facebook..  current/sad   Can't even send a message to other users...

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

After I went through all that diagnosis yesterday, I realized that'd it'd probably be better just to hijack and change their Javascript. I had looked at that thought this morning but was thoroughly confused by the Javascript in the Ajax Login module. That's not to say their code is sloppy, just that I don't know the libraries they are using or their overall code in general, so it was going to take too much investigation.

With your suggestion above though, we can easily make that change and see what may be going wrong now. We'll get on it and hopefully have something to you later this weekend. My (more lengthy) changes above should work, but I understand those aren't as optimal as a line or two of changes would be.

Thanks for the feedback and patience,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,

I'm going to undo his changes and apply your code patch. Will let you know how it worked here.

Thanks for your efforts!

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,
Will wait to see what you come up after this weekend. (I'm crossing my fingers for a final solution that works for everybody current/smile )
Thanks!

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex.

Sent you an email with the latest patch the developer suggested. maybe it can help..

Thanks!

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

I hope so.  Crossing my fingers.

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Hey guys. I just tried the minor code change above and I'm not seeing any difference. The popup that's appearing looks to be coming from the improved login extension, not JFBConnect. So, I'm really not seeing any change with this patch.

I did some testing and tried to shuffle things around the best I could. Unfortunately, I don't know the Dojo framework that's being used here, so I don't know how the process of attaching Javascript events, stopping other ones, and the general flow should work. My ugly code changes above did seem to work for me. I'd much prefer a 2 line change as well, but I can't seem to figure that out.

On a side note, we've definitely decided that the next big JFBConnect release is going to have a vastly improved Login module. I can't guarantee it's looks or full functionality will be the same as Improved Login, which is pretty nice, but it will definitely be an imrpvoment (design and functional) over the current SCLogin module. The update will be a part of the 5.1 release, due out in April.

I'm still more than willing to help with this issue, but I just don't know what to try next other than the ugly changes above. If there's another patch from the developer, we'll gladly test. I'm afraid I won't be able to fix much of what they recommend though with my lack of knowledge regarding their framework.

Keep me posted on what you find,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex,

In  /modules/mod_improved_ajax_login/mod_improved_ajax_login.php  (line 267)

if (window.regParams) dojo.mixin(params, window.regParams);
  if (!window.ologin) window.ologin = new WW.Login(params);
";


changed to:

if (window.regParams) dojo.mixin(params, window.regParams);
  if (!window.ologin) window.ologin = new WW.Login(params);
  var fi = dojo.byId('facebookImg');
  if (fi) dojo.connect(fi, 'onclick', function(e) {
    e.stopPropagation();
    jfbc.login.login_custom();
  });
";



And it worked! I'm registering new users using the facebook icon on mod_improved_login and it's calling JFBConnect (all the JomSocial fields are being correctly mapped, including facebook avatar).  I don't know if it will work with the buttons, but definitely does for the Icon.

I'm using the Facebook App ID on the module's config, but it doesn't seem to be interfering with other JFBConnect functionalities. Maybe the Dojo is not propagating anymore with the changes above.. 

Anyway one could also try your  social.php trick (together with the suggested patch above)
<?php if ($socialpos=='XYZ') require dirname(__FILE__).'/social.php'; ?>

to avoid enabling the module's facebook connect...

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

What version of  are you using?  I don't see those lines of code in the  /modules/mod_improved_ajax_login/mod_improved_ajax_login.php

I am using version 1.149

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Hi,

I'm using 1.186

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Hmm, I can't upgrade right now because of certain code changes made by Offljan on my current version.

Guess I will have to modify social.php as Alex suggested?

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Yeah, Alex patch also works. You should give it a try current/wink

davcar1
David
useravatar
Offline
28 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Glad to hear something works. Sorry my is a nasty chunk of changes, but it's about the best you can get from me due to my lack of knowledge of their extension.

Best of luck, and keep us posted on anything you find, fix, or run into.

Thanks,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

Alex, regarding this step: "Then, the final step is to edit the theme.css.php file. You need to search for socialIco and btnIco and for each instance, add a new setting called socialIcoJfbc and btnIcoJfbc, respectively. There's a lot of them, but get them all. When done, a block like: "

I am a little confused.  I cannot seem to figure out how to make the changes based on the example you provided. 

The code from the file is: *removed*

planethop
useravatar
Offline
49 Posts
Active Subscriptions:

None
Administrator has disabled public posting. Please login or register in order to proceed.

Re: JFBConnect Compatibility with Other Third-Party Login modules?

I removed the large amount of code you added. I believe the files are slightly different with your version vs what I was working with, which is why I can't just give the file with the updates.

I do realize that I missed saying something above. You need to search for socialIco, btnIco, *and* loginBtn. The example I gave above was for loginBtn, but without mentioning that, it was likely pretty confusing. As another example, you just need to do a search through that files contents for "socialIco" and "btnIco" and "loginBtn". Each time you see that text, duplicate it with a new setting name called "socialIcoJfbc" and "btnIcoJfbc" and "loginBtnJfbc". So, if you search for "btnIco", you'd find the following block of code:

Code:

.btnIco {

  display: block;
  float: left;
  background: transparent no-repeat 1px center;
  width: 20px;
  border-right: 1px #<?php echo $buttoncomb[1]?> solid;
  box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
  -webkit-box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
}

Update that to be:

Code:

.btnIco,

.btnIcoJfbc { ##### add this new .btnIcoJfbc line and make sure you put a , at the end of the line above
  display: block;
  float: left;
  background: transparent no-repeat 1px center;
  width: 20px;
  border-right: 1px #<?php echo $buttoncomb[1]?> solid;
  box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
  -webkit-box-shadow: 1px 0 0 rgba(255, 255, 255, 0.5);
}

Hope that helps, and keep us posted,
Alex

If you use our extensions, please consider leaving a rating and review at the Joomla! Extension Directory:
JFBConnect | SCLogin

alzander
Alex
useravatar
Offline
24016 Posts
Support Specialist
Administrator has disabled public posting. Please login or register in order to proceed.
There are 0 guests also viewing this topic
There are 0 users also viewing this topic

Board Info

Board Stats
 
Total Topics:
11613
Total Polls:
0
Total Posts:
48800
Posts today:
17
User Info
 
Total Users:
47658
Newest User:
lszlsz
Members Online:
3
Guests Online:
673

Social Stream
SourceCoast Joomla Social Extensions
Friday, 25 May 2018
JFBConnect 8.0 Coming Soon! Stay tuned.
Refer and Earn

Like our extensions? You're not alone! That's why they're used on tens of thousands of websites. Now you can earn 20% of any sale you refer to SourceCoast.com.

We provide excellent documentation, well laid out sales pages and great support. All you need to do is spread the word and we'll take care of the rest.

Learn About Our Affiliate Program