Menu Routing Errors

There are two menu items available for facebook activity and settings.

index.php?option=com_jfbconnect&view=opengraph&layout=activity
index.php?option=com_jfbconnect&view=opengraph&layout=settings

When either of these two menu items are used, the proper controller is not being invoked. This results in the default JFBConnectController being called and not the proper JFBConnectControllerOpenGraph controller. As such, the wrong display() function is called. While this still ends up invoking the correct view, this means that calls to $view->setModel() are not made and the view fails as the models aren't populated.

In jfbconnect.php, you derive the controller using the "controller" query string argument which a Joomla menu item will never pass. You must use "view" for this purpose.

The fix is to change line 21 in jfbconnect.php to read as such:

$controller = JRequest::getCmd('controller', JRequest::getCmd('view', ''));

Since you use "controller" in your internal links, this will create a fallback condition whereby when controller is not found, it looks to see if view can be used. This will make the menu items work properly (and any others that you may create/use in the future).

Let's also take this a step further - since you create menu items using view/layout (as Joomla will do by default), your redirect settings in controllers really should match.

For example, on the open graph activity view/layout, there is a call to userdelete() which, after doing its job, does a setRedirect(). Unfortunately, this sets the redirect using the generic controller=opengraph query string.

While this works, it is NOT the same route for menu items. That means any site owner who sets up menu items will find, after deleting an open graph action, that the page displayed is an orphan. Module settings will not be respected and the URL will be different.

The setRedirect() in this case really needs to match what any menu item linked to this page would have. As such, the setRedirect() call really should look like this:

$this->setRedirect(JRoute::_('index.php?option=com_jfbconnect&view=opengraph&layout=activity', false));

This matches the properly-routed URL set by the menu and will return the user to the proper page, with the proper Itemid.

alzander wrote: We definitely appreciate the feedback. I also hope all these issues aren't getting you fed up and that JFBConnect is still getting you closer to where you want to be, and faster as well.

Totally put that out of your head. Your component is light years ahead of anyone else, and your support and attention to issues speaks volumes. It's a pleasure to work with you. I'm more than pleased to help out here on a bunch of these issues because I'm getting weeks worth of Facebook coding "for free" out of the purchase of the component (and, in reading your code, a good understanding of how it all works that's worth more than the $50 I'd pay for a book on the subject, if such a book even existed).

There's no question that I'm getting the bigger value side of this