Suggestion to internationalization

Alexandre,
I'm assuming you mean that it's not picking up the language set by the Joomla user? If so, I believe you're correct that we aren't doing it correctly (just getting the default of the site as a whole). I don't know immediately if your answer is the perfect solution, but if it works for you, great. I've added it to our tracker to investigate further for our next major release in July, and I can see this change (or something similar) being added then.

If I'm missing what you're saying, just let me know.

Thanks,
Alex

Alexandre,
Yes, that should be the only place. Everywhere else, we should be using Joomla to load the appropriate language file, and it will do it automatically based on the current user's language (falling back to the default if none is selected). The location you found is the only place that we load the Facebook Javascript library, which is what translates all of the Facebook widgets (Like, Comments, etc). There isn't anywhere else that should have this issue.

I'm assuming you're solution worked? If so, we'd love to know cause it will help us make sure we're implementing the right thing. It's already logged as an issue to be fixed in the next release, and I don't see any reason why we'd push it back.

Thanks again for you feedback,
Alex

Alexandre,
I wanted to follow up on this post since we just implemented the solution to this problem for our upcoming release. It's a little different than your change, so wanted to call it out. Instead of using getLocale, we are using getTag. The locales returns an array of many different locales, like de_DE.UTF8, de_DE_CH.UTF8, etc. In order to use these values, you'd need to strip the .UTF8 part. Additionally, depending on the ordering of the locales, the best one might not be in the first spot of the array.

So, to fix for the upcoming release, we're doing the following, which only returns the most common locale for the language (de_DE, for example):
Feel free to try that solution and see if it works for you. We'd love to hear your feedback.

Glad to hear it. We got another report from a user with a similar, but slightly different language issue, that it was working for them too. Additionally, they are using JoomFish, wish means it's compatible with that too.

So, for now, we're marking this as closed in our bug-tracker and, again, will be including in the next version as well.

Thanks for the feedback!